[ 
https://issues.apache.org/jira/browse/DERBY-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499835
 ] 

A B commented on DERBY-2654:
----------------------------

Thank you for committing this, Myrna.

When I saw the commit message in my Inbox the parenthetical "(in embedded 
mode)" jumped out at me--and only then did I realize that the documation as 
committed doesn't mention that the relevant APIs only (currently) work in 
embedded mode.  That was my mistake--I completely forgot to include that info 
in my original draft.

Kim, would it be possible to post a follow-up patch to address this?  We would 
have to add something to indicate that the following six methods are not 
suppoted in client/server mode?

  connection30.html:

    prepareStatement(String sql, int [] columnIndexes)
    prepareStatement(String sql, String [] columnNames)

  statement30.html:

    execute(String sql, int [] columnIndexes)
    execute(String sql, String [] columnNames)
    executeUpdate(String sql, int [] columnIndexes)
    executeUpdate(String sql, String [] columnNames)

Maybe the best place to put this is on the crefjavstateautogen.html page, where 
we now have:

<begin>

Users can indicate that auto-generated columns should be made available for 
retrieval by passing one of the following values as a second argument to the 
Connection.prepareStatement, Statement.execute, or Statement.executeUpdate 
methods:

    * A constant indicating that auto-generated keys should be made available. 
The specific constant to use is Statement.RETURN_GENERATED_KEYS.
    * An array of the names of the columns in the inserted row that should be 
made available. If any column name in the array does not designate an 
auto-increment column, Derby will throw an error.
    * An array of the positions of the columns in the inserted row that should 
be made available. If any column position in the array does not correlate to an 
auto-increment column, Derby will throw an error.

<end>

Would it be possible to add a note at the end of the second and third bullets?  
Maybe something like:  "Note: this is currently only supported when running in 
embedded mode."

That's just a quick suggestion, though.  If there's a better way to relay this 
info, feel free to go with it.
Sorry for missing this earlier...

> Document newly-supported (in embedded mode) JDBC methods for autogenerated 
> keys.
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-2654
>                 URL: https://issues.apache.org/jira/browse/DERBY-2654
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.3.0.0
>            Reporter: A B
>            Assignee: Kim Haase
>             Fix For: 10.3.0.0
>
>         Attachments: changes.txt, changes.txt, DERBY-2654-2.diff, 
> DERBY-2654-2.zip, DERBY-2654.diff, DERBY-2654.zip
>
>
> Several JDBC methods for specifying auto-generated key columns were 
> implemented in embedded mode as part of DERBY-2631. Derby documentation 
> should be updated to reflect those changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to