[
https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500329
]
V.Narayanan commented on DERBY-2730:
------------------------------------
Thank you for the reviews and comments.
> 1) Looks fair enough, although I will not consider the review done until
> after DERBY-2711 is committed and a clean patch submitted.
The Derby-2711 changes will not exist when I submit a follow-up patch once
Derby-2711
is committed.
You have mentioned clean patch, so I just wanted to ensure that you did
feel unhappy with the alignment, non-presence of whit-space diffs and other
general
standard requirements of clean code.
Pls do mention if the code is falling in quality in any of these and
I will correct them duly.
> 2) There's no explanation why Clob.getCharacterStream isn't a part of this
> patch.
I am sorry I should have mentioned this in the comments.
Derby-2712 seems to be making changes to the wrapper in the same way
Derby-2711 does. I could therefore not pull-out a patch as I have done in the
case of Derby-2711 and make changes in way of a review patch since any
changes to current classes would have had a conflict from the patch for
Derby-2712.
Can someone familiar with Derby-2712 pls tell me if the assumption I have made
in the
above comment is correct?
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos,
> long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff,
> GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob
> interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
