[
https://issues.apache.org/jira/browse/DERBY-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500609
]
Knut Anders Hatlen commented on DERBY-2472:
-------------------------------------------
Thanks for the review, Jørgen!
It's certainly possible to let dataFileNotFound() take an Exception parameter
instead of a Throwable since it's only ever called with FileNotFoundException
or SecurityException. I chose to use a more generic data type in the signature
to allow different uses in the future, but it doesn't seem likely that anyone
will call that method with a Throwable, so I'll change it.
> Use Throwable.initCause() to improve error reporting
> ----------------------------------------------------
>
> Key: DERBY-2472
> URL: https://issues.apache.org/jira/browse/DERBY-2472
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Miscellaneous
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-2472_initial_patch.diff, embedsqlexception.diff,
> embedsqlexception.stat, initCause.diff, initCause.stat, initCause2.diff,
> initCause2.stat, seenext.diff, seenext.stat, setnext.diff, setnext.stat,
> setStackTrace-v2.diff, setStackTrace.diff, standardexception.diff,
> standardexception.stat
>
>
> As Derby has moved to J2SE 1.4, Throwable.initCause() can now be used to
> improve error reporting.
> As stated in the initial commit (that was backed out, see below):
> 'Set Throwable.initCause() in a couple of locations at the JDBC level where
> we setup nested SQLExceptions.
> This means that automatically the stack trace for a database failed to start
> includes the reason
> for the failure, rather than just "see next exception". This is a great help
> when running
> JUnit tests and getting failures to start a database.'
> The initial commit was backed out because it broke numerous tests under JDK
> 1.6, and the author indicated he had no time to investigate.
> The patch caused no failures when running the tests with Java SE 5.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
