[ 
https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502891
 ] 

Manish Khettry commented on DERBY-1623:
---------------------------------------

Sorry, I guess not all issues were addressed.

re: space vs tabs-- the new file AnsiTrimTest is all spaces I think. Please do 
not put any tabs in there!
6-- trim in SQLChar/StringDataValue is not being generated by the code 
generator anymore. However I do not know if there are existing triggers or 
query plans on disk which refer to it so I did not remove it. If upgrade is not 
an issue then by all means the trim function should go away or ansiTrim should 
just be named trim.
8. I hadn't thought of documentation but I could take a stab at it or atleast 
open a subtask for it.
If it does make it to 10.3, then it should be buddy tested.



> Add ANSI TRIM implementation
> ----------------------------
>
>                 Key: DERBY-1623
>                 URL: https://issues.apache.org/jira/browse/DERBY-1623
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Emmanuel Bernard
>            Assignee: Manish Khettry
>         Attachments: 1623-parser-guess.diff, 1623.patch.txt, 
> 1623_take2.patch.txt, AnsiTrimTest.java, compile_error.jj, sqlgrammar.jj.diff
>
>
> JPA is requiring databases to support this ANSI feature esp the ability to 
> chose the trimmed character
> TRIM([ [ LEADING | TRAILING | BOTH ] [ chars ] FROM ] str)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to