[
https://issues.apache.org/jira/browse/DERBY-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504167
]
Knut Anders Hatlen commented on DERBY-2274:
-------------------------------------------
The patch looks fine to me. A couple of comments, though:
1) The new copy constructor in TestConfiguration could perhaps use the existing
copy constructor, like this:
this(copy);
this.ssl = ssl;
Actually, when I think more about it, perhaps a static copy method would be
better. If we want another copy constructor that changes one string property
later, we are kind of lost. What about:
public static TestConfiguration copyConfigurationForSSL(TestConfiguration
template, String ssl) {
TestConfiguration copy = new TestConfiguration(template);
copy.ssl = ssl;
return copy;
}
2) In NetworkServerTestSetup.getDefaultStartupArgs(), I was wondering whether
it would be more correct to pass in "-ssl off" when getSsl().equals("off")
rather than skipping those arguments.
3) Same as (2) for getNetworkServerControl().
4) I'm not sure whether it is OK to call Class.forName() and
DriverManager.getConnection() directly from the test method. What about using
JDBCDataSource.getDataSource() and JDBCDataSource.setBeanProperty() instead?
5) Should SSLTest also have test cases for other SSL modes?
6) What about splitting the test method into to separate test cases (one
positive and one negative)?
7) The boxes which are drawn around the comments exceed 80 characters (which
should be unneccessary since the comments are very short).
8) In NetworkServerTestSetup.getNetworkServerControl(), would it be better to
restore the derby.drda.sslMode property to its old value rather than always
removing it?
> Implement testing for SSL communication
> ---------------------------------------
>
> Key: DERBY-2274
> URL: https://issues.apache.org/jira/browse/DERBY-2274
> Project: Derby
> Issue Type: Sub-task
> Components: Network Client, Network Server
> Reporter: Bernt M. Johnsen
> Assignee: Bernt M. Johnsen
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2274.diff, DERBY-2274.stat, SSLTestServerKey.key
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
