[
https://issues.apache.org/jira/browse/DERBY-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513753
]
Kathey Marsden commented on DERBY-2942:
---------------------------------------
Hi Ramin,
Thanks for the patch. A few minor comments:
There are a few places where it says
*
* DERBY-2943 -- execute() and executeUpdate() return different
* SQLState in embedded and network client
*
* Disabling Network Client
*/
if (!usingDerbyNetClient())
I think it would be better to test with network client but just use the
usingDerbyClient() to check for a different exception.
- The connection you get with getConnection in CleanDatabaseSetup is never used
so can be removed.
- There is no longer a need to close the statements created with
createStatement() they are now cleaned up automatically.
> Convert jdbcapi/statementJdbc30.java to JUnit
> ---------------------------------------------
>
> Key: DERBY-2942
> URL: https://issues.apache.org/jira/browse/DERBY-2942
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Attachments: DERBY-2942v0.diff, DERBY-2942v0.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
