[
https://issues.apache.org/jira/browse/DERBY-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515752
]
Kathey Marsden commented on DERBY-2945:
---------------------------------------
Hi Ravinder, your patch looks good. Only a few minor points.
The statements created with createStatement() will be closed automatically so
you don't need the s.close()
You can use JDBC.assertSingleValueResultSet instead of the rs.next() calls and
assertEquals()
It would be good to have javadoc for the methods.
Also was primaryKey.sql not in a suite before? I see from the test page that
it says it was in derbylang but don't see a trace of it.
Kathey
> convert lang/primarykey.sql to JUnit
> ------------------------------------
>
> Key: DERBY-2945
> URL: https://issues.apache.org/jira/browse/DERBY-2945
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2945.diff, DERBY-2945.diff-2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
