[
https://issues.apache.org/jira/browse/DERBY-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518527
]
Kathey Marsden commented on DERBY-2968:
---------------------------------------
I looked at your new test and have the following comments:
- Can you change the test setup to not have assertions as recommended by Dan.
- Change the test to have space indentation instead of tabs and fix indentation
to be consistent
- There is a typo, Bug 29994 instead of 2994.
- The new test needs to be added to lang/_Suite.java so it will run.
Maybe it would be good to name your patches v1,v2 etc instead of "final", just
in case changes are needed.
Kathey
> convert lang/renameTable.sql to JUnit
> -------------------------------------
>
> Key: DERBY-2968
> URL: https://issues.apache.org/jira/browse/DERBY-2968
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ravinder Reddy
> Assignee: Ravinder Reddy
> Attachments: DERBY-2968.diff, DERBY-2968.diff.final
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
