[ 
https://issues.apache.org/jira/browse/DERBY-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519152
 ] 

Kathey Marsden commented on DERBY-2995:
---------------------------------------

I think this fixture is ok as is except for maybe a comma after the word fail.  
Following rename should fail, to prove that, not the following rename should 
fail to prove that #:).

testDuplicateIndexWithPreparedStatement 
On the cleanup e.g. drop tables you should just have s.executeUpdate("drop 
table t3) instead of an assertion


Why is this fixture commented out?  There doesn't seem to be an open cursor.

  /*-- cannot rename an index when there is an open cursor on it
     public void testRenameIndexWithOpenCursor() throws SQLException {
     Statement s = createStatement(ResultSet.TYPE_FORWARD_ONLY , 
ResultSet.CONCUR_UPDATABLE);
     assertUpdateCount(s , 0 , "create table t1(c11 int, c12 int)");
     assertUpdateCount(s , 0 , "create index i1 on t1(c11)");
     assertStatementError("X0X95" , s , "rename index i1 to i1r");
     //-- following rename should pass because cursor c1 has been closed
     assertUpdateCount(s , 0 , "rename index i1 to i1r");
     assertUpdateCount(s , 0 , "drop table t1");
     }*/


> convert lang/renameIndex.sql to JUnit
> -------------------------------------
>
>                 Key: DERBY-2995
>                 URL: https://issues.apache.org/jira/browse/DERBY-2995
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Ravinder Reddy
>            Assignee: Ravinder Reddy
>             Fix For: 10.3.1.1
>
>         Attachments: DERBY-2995.diff-p1
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to