[
https://issues.apache.org/jira/browse/DERBY-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521414
]
Knut Anders Hatlen commented on DERBY-2926:
-------------------------------------------
Thanks for the new patch Jørgen. Your comments sound reasonable to me. Some new
comments:
- I assume the changes to index.html should be discarded.
- ReplicationLogBuffer.validData() is synchronized on this. Did you mean
outputLatch?
- ReplicationLogBuffer.switchDirtyBuffer() mentions synchronized(this) in its
javadoc. Should it say listLatch?
> Replication: Add a log buffer for log records that should be shipped to the
> slave
> ---------------------------------------------------------------------------------
>
> Key: DERBY-2926
> URL: https://issues.apache.org/jira/browse/DERBY-2926
> Project: Derby
> Issue Type: Sub-task
> Components: Services
> Affects Versions: 10.4.0.0
> Reporter: Jørgen Løland
> Assignee: Jørgen Løland
> Fix For: 10.4.0.0
>
> Attachments: bytebuffer_v1-fixheader.diff,
> bytebuffer_v1-fixheader.stat, bytebuffer_v1.diff, bytebuffer_v1.stat,
> bytebuffer_v1a.diff, bytebuffer_v1a.stat, bytebuffer_v2.diff,
> bytebuffer_v2.stat
>
>
> When a Derby instance has the master role for a database, log records are
> shipped to the slave to keep it up to date. A buffer is needed because the
> log records should not be shipped one at a time. Also, writing the log
> records to a buffer instead of sending them immediately removes the network
> communication from the critical path for the transaction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
