[ 
https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522494
 ] 

Jørgen Løland commented on DERBY-2954:
--------------------------------------

Hi Narayanan,

I reviewed the patch, and I think it looks good. I have one question, though: 
Since this patch adds a command that a user can issue but does not do anything, 
would it be good to print something like "Replication not implemented yet" to 
the console? You could for instance add one more console property message that 
is called from the setReplicationDB method.

I am not sure if printing this message is necessary since the functionality 
will be added before a new release is made - just a thought.

> Add commands to NetworkServerControl for interacting with the replication 
> functionality
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-2954
>                 URL: https://issues.apache.org/jira/browse/DERBY-2954
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.4.0.0
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: NetworkServerControlCmds_v1.diff, 
> NetworkServerControlCmds_v1.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to