[
https://issues.apache.org/jira/browse/DERBY-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523199
]
V.Narayanan commented on DERBY-2921:
------------------------------------
Thank you for the comments Jorgen!
> 2) I wonder if defaulting to localhost is a good idea -
> replicating a db back to the same host seems to be
> little worth. Maybe we should require the host to be
> specified?
I was thinking along the lines of the NetworkServer. It was defaulting to
localhost. I agree that replicating to the same host seems little worth.
(except while testing I guess! localhost replication would be very useful
while writing tests that integrate into the junit tests.)
But it seems harmless to me to allow it to default to localhost. Currently
no message is printed though. Maybe the message addition should be done
as part of the NetworkServer command that starts replication.
> Further, the defaultNetworkValues method
> in both transmitter and receiver sets both host and port to default
>even if only one of these are not specified.
I agree! I shall modify this.
I shall fix 1), 3) and 4) also in the follow-up patch I will be submitting.
Thanks once again for the comments
> Replication: Add a network service that connects the master and slave Derby
> instances
> -------------------------------------------------------------------------------------
>
> Key: DERBY-2921
> URL: https://issues.apache.org/jira/browse/DERBY-2921
> Project: Derby
> Issue Type: Sub-task
> Components: Services
> Affects Versions: 10.4.0.0
> Reporter: Jørgen Løland
> Assignee: V.Narayanan
> Attachments: Replication_Network_v1.diff,
> Replication_Network_v1.stat, Replication_Network_v2.diff,
> Replication_Network_v2.stat, Replication_Network_v3.diff,
> Replication_Network_v3.stat
>
>
> A network connection is required between the master and slave Derby instances
> of a replicated database. The connection will be used to send many kinds of
> messages, including:
> * log records
> * the database (when replication is started)
> * master -> slave commands (like "stop replication")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
