[ 
https://issues.apache.org/jira/browse/DERBY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526182
 ] 

Kathey Marsden commented on DERBY-1272:
---------------------------------------

Hi Raman,

Thanks for bringing this issue back to life.  It will surely be very helpful to 
users and support folks.  I looked at the patch and tried it out and it all 
seemed to work fine.  A few comments.
- I am concerned about adding $derby.tools.src.dir to the build.xml.  Sysinfo 
is available in derby.jar, but the other tools classes are not.  Adding 
derby.tools.src.dir allows access to all the tools classes, which is not ideal. 
 I wonder if using reflection can avoid the need to change the build.xml.

-  Sysinfo prints security exceptions for information it can't access. e.g.
Java user name:  Security Exception: java.security.AccessControlException: 
Access denied (java.util.PropertyPermission user.name read)

I am concerned that this might become a red herring for those debugging a 
problem and thinking this might be the root of it.   DERBY-1273 is filed to 
improve the message though and I think we can handle that as a separate issue.  
I asked for some feedback from some support people to get an additional 
opinion. I'll let you know what I hear.

-  The test doesn't seem to actually test that sysinfo printed.  It would be 
good to have a test that tests that.

Kathey


> Change sysinfo to print to error log (derby.log) on boot of derby  if 
> derby.stream.error.logSeverityLevel=0
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1272
>                 URL: https://issues.apache.org/jira/browse/DERBY-1272
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 10.1.2.1, 10.1.3.1, 10.2.1.6
>            Reporter: Kathey Marsden
>            Assignee: Ramin Moazeni
>            Priority: Minor
>         Attachments: derby-1272-pre.diff, derby-1272-pre2.diff, 
> derby-1272-pre3.diff, derby-1272-v4.diff, DERBY-1272v5.diff
>
>
> It is often very difficult to collect correct sysinfo output from user 
> environments because  sysinfo run from the commandline does not have the same 
> classpath as the jvm that started Derby or Derby was loaded with a custom 
> classloader.
> It would be very helpful in assisting users in diagnosing their issues if 
> sysinfo dumped to the error log if  derby.stream.error.logSeverityLevel=0  or 
> even by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to