[
https://issues.apache.org/jira/browse/DERBY-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527892
]
V.Narayanan commented on DERBY-3051:
------------------------------------
Thank you for the patch Jorgen. The patch looks very good.
I just have one very small doubt
Would it be OK for the startReplicationMasterRole and stopReplicationMasterRole
of the ReadOnly class to both throw an exception Or maybe the stopreplication
inadvertently called on a read only database would have failed somewhere before
itself since the replication would not have been started in the first place and
this code is ideally speaking not reachable.
> Replication: Modify logging subsystem to append log records to the
> replication buffer when in replication master mode
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3051
> URL: https://issues.apache.org/jira/browse/DERBY-3051
> Project: Derby
> Issue Type: Sub-task
> Components: Services, Store
> Affects Versions: 10.4.0.0
> Reporter: Jørgen Løland
> Assignee: Jørgen Løland
> Attachments: derby_3051_1.diff, derby_3051_1.stat
>
>
> When Derby has the replication master role for a database 'x', it should ship
> all log records generated for this database to the Derby with the slave role.
> A replication buffer was added to Derby in DERBY-2926. This issue is for
> modifying the logging subsystem to append log records to this buffer every
> time a log records is appended to the disk buffer (LogAccessFile). This will,
> of course, only be done if it has the master role.
> Currently, I have identified two modifications that will be required in
> LogToFile:
> * LogToFile#appendLogRecord needs to append to the replication buffer after
> appending to the disk buffer
> * LogToFile#flush (i.e., the method used to force buffered log records to
> disk) must notify the Master Controller (DERBY-2977) that a flush has taken
> place. The MasterController will decide if any action is required because of
> this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
