[ https://issues.apache.org/jira/browse/DERBY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528406 ]
Dag H. Wanvik commented on DERBY-3072: -------------------------------------- Thanks for providing the docs, Rick. Just some initial comments: * Should the docs show an example that actually implements the ResultSet interface (the current example passes on one from another driver)? Maybe adding a worked example to demos would be good, and just add a pointer in the docs. What level of JDBC ResultSet (2,3 or 4) is implemented doesn't matter as far as I understand, but maybe that fact should be called out explicitly. * The description for VTICosting override: getEstimatedCostPerInstantiation doesn't mention what units cost is expressed in. I know this is a bit vague in Derby, but I think the docs should attempt some kind of guidance. The interface source code doesn't speak about it either as far as I can see (default is 100000, but unit is unclear). > User documentation for Table Functions > -------------------------------------- > > Key: DERBY-3072 > URL: https://issues.apache.org/jira/browse/DERBY-3072 > Project: Derby > Issue Type: New Feature > Components: Documentation > Reporter: Rick Hillegas > Assignee: Rick Hillegas > Attachments: derby-3072-01-basic-aa.diff, derby-3072-01-basic-aa.tar > > > This issue tracks changes to the user guides to describe table functions. > This is the work needed for the "Documentation" section of the functional > spec attached to DERBY-716. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.