[
https://issues.apache.org/jira/browse/DERBY-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
V.Narayanan updated DERBY-2921:
-------------------------------
Attachment: Replication_Network_v7.stat
Replication_Network_v7.diff
Thank you for the detailed reviews and comments Oystein!
1 - I did a scan of all the javadoc in the current patch and have modified
them to comply to the suggestions.
2 - I have added @throws tag to all the exceptions.
3 - I have changed the Initator to accept a long do the following now,
ReplicationMessage initiatorMsg = new ReplicationMessage
(ReplicationMessage.TYPE_INITIATE, new Long(
ReplicationMessage.serialVersionUID));
I have also changed the name of the method to sendInitiatorAndReceiveAck
since it first sends a initiator messages and receives a ack corresponding
to that.
4 - The method names have been changed to getHostAddress() and getPortNumber().
5 - I have made serverSocket local.
6 - The methods in SocketConnection do not cast anymore. The casts are instead
done in the place where these methods are used.
7 - I have changed the methods to do the reset and the flush.
8 - TYPE_LOG - changed to LogRecord
TYPE_INITIATE - uses a Long now.
VERSION_MISMATCH has been removed.
> Replication: Add a network service that connects the master and slave Derby
> instances
> -------------------------------------------------------------------------------------
>
> Key: DERBY-2921
> URL: https://issues.apache.org/jira/browse/DERBY-2921
> Project: Derby
> Issue Type: Sub-task
> Components: Services
> Affects Versions: 10.4.0.0
> Reporter: Jørgen Løland
> Assignee: V.Narayanan
> Attachments: Replication_Network_expln_v6.txt,
> Replication_Network_v1.diff, Replication_Network_v1.stat,
> Replication_Network_v2.diff, Replication_Network_v2.stat,
> Replication_Network_v3.diff, Replication_Network_v3.stat,
> Replication_Network_v4.diff, Replication_Network_v4.stat,
> Replication_Network_v5.diff, Replication_Network_v5.stat,
> Replication_Network_v6.diff, Replication_Network_v6.stat,
> Replication_Network_v7.diff, Replication_Network_v7.stat
>
>
> A network connection is required between the master and slave Derby instances
> of a replicated database. The connection will be used to send many kinds of
> messages, including:
> * log records
> * the database (when replication is started)
> * master -> slave commands (like "stop replication")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
