[ 
https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536605
 ] 

Dag H. Wanvik commented on DERBY-2065:
--------------------------------------

Thanks for the release note, Jørgen!
Looks good, some comments!

>Summary of Change
>Error code changed for embedded connection when a connection with an open 
>transaction is closed.

The connection is not actually closed, so I would say "attempted
closed".

>Incompatibilities with Previous Release

I'd try to be a little more precise in this section, for example:

Embedded applications that are dependent on the error code
<it>ever</it> being "25000" could start failing.

Embedded applications that are dependent on the error code
<it>never</it> being "25001" could start failing.



> Rationale for Change
> Harmonize error codes raised by the client and embedded drivers. 

(suggest add) .. thereby also making the embedded driver compatible
with the SQL standard.



> Network and embedded difference in SQLSTATE and message when 
> Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when 
> Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to