[ 
https://issues.apache.org/jira/browse/DERBY-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537935
 ] 

Knut Anders Hatlen commented on DERBY-2903:
-------------------------------------------

Two small nits:

  1) outputEncoding is both an (unused) instance variable and a local variable 
in testClassPathChecker. I think one of them should be removed (if the instance 
variable is kept, it would probably be better to make it static final)

  2) rawBytes is only needed in the test method, so I think it could be a local 
variable instead of an instance variable. Then we could also get rid of the 
tearDown() method

I don't understand the System.out problems, so I can't help you there. You may 
also consider putting the final setSystemOut() into a finally clause (or 
perhaps tearDown()) so that we don't end up redirecting System.out for all 
subsequent tests if sysinfo.main() fails.

> RunClassPathTester regression test gets diff because of error message 
> difference
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-2903
>                 URL: https://issues.apache.org/jira/browse/DERBY-2903
>             Project: Derby
>          Issue Type: Test
>          Components: Regression Test Failure
>         Environment: Generating report for RunSuite derbyall  null null null 
> true 
> ------------------ Java Information ------------------
> Java Version:    1.4.2
> Java Vendor:     IBM Corporation
> Java home:       c:\10.3_Testing\ibm142\jre
> Java classpath:  
> c:\10.3_Testing\jars\lib\derby.jar;c:\10.3_Testing\jars\lib\derbytools.jar;
> c:\10.3_Testing\jars\lib\derbynet.jar;c:\10.3_Testing\jars\lib\derbyclient.jar;c:\10.3_Testing\jars\lib\derbyrun.jar;
> c:\10.3_Testing\jars\test\derbyTesting.jar;c:\10.3_Testing\jars\tools\junit.jar;c:\10.3_Testing\jars\tools\jakarta-oro-2.0.8.jar
> OS name:         Windows Server 2003
> OS architecture: amd64
> OS version:      5.2 build 3790 Service Pack 1
> Java user name:  cloudtest
> Java user home:  C:\Documents and Settings\cloudtest
> Java user dir:   C:\10.3_Testing\platformtesting\ibm142_derbyall
> java.specification.name: Java Platform API Specification
> java.specification.version: 1.4
> --------- Derby Information --------
> JRE - JDBC: J2SE 1.4.2 - JDBC 3.0
> [C:\10.3_Testing\jars\lib\derby.jar] 10.3.1.0 beta - (548006)
> [C:\10.3_Testing\jars\lib\derbytools.jar] 10.3.1.0 beta - (548006)
> [C:\10.3_Testing\jars\lib\derbynet.jar] 10.3.1.0 beta - (548006)
> [C:\10.3_Testing\jars\lib\derbyclient.jar] 10.3.1.0 beta - (548006)
> ------------------------------------------------------
>            Reporter: Mike Matrigali
>            Assignee: Myrna van Lunteren
>         Attachments: DERBY-2903_modapi.diff, DERBY-2903_noapimod.diff, 
> DERBY-2903_noapimod.diff2
>
>
> Got the following diff because of access vs. Access in error message.  
> probably a master update needed.
> ********* Diff file derbyall/demo/demo/RunClassPathTester.diff
> *** Start: RunClassPathTester jdk1.4.2 demo:demo 2007-06-20 14:32:54 ***
> 3 del
> <    Unable to access Protection Domain or Code Source for class interface 
> org.apache.derby.database.Database: 
> access denied (java.lang.RuntimePermission getProtectionDomain)
> 3a3
> >    Unable to access Protection Domain or Code Source for class interface 
> > org.apache.derby.database.Database: 
> Access denied (java.lang.RuntimePermission getProtectionDomain)
> 5 del
> <    Unable to access Protection Domain or Code Source for class class 
> SimpleApp: 
> access denied (java.lang.RuntimePermission getProtectionDomain)
> 5a5
> >    Unable to access Protection Domain or Code Source for class class 
> > SimpleApp: 
> Access denied (java.lang.RuntimePermission getProtectionDomain)
> Test Failed.
> *** End:   RunClassPathTester jdk1.4.2 demo:demo 2007-06-20 14:32:56 ***

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to