[ 
https://issues.apache.org/jira/browse/DERBY-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vemund Østgaard updated DERBY-3156:
-----------------------------------

    Attachment: 3156-diffv2.stat
                3156-diffv2

Thank you for looking at the patch, Dan.

I've now uploaded a new patch (3156-diffv2) with the following changes, based 
on the comments:

I looked at the use of static fields. A few fields have to be static for the 
test to work (code accessed by Derby in a static context), but there shouldn't 
be any static fields now that don't have to be.

I had postponed making the test work with a security manager, and forgot about 
it when I submitted the patch on Friday. I've looked at it now and believe I 
have it working with the security manager the way it should. 

I added 10 different wrapper-methods for the doPrivileged stuff related to 
accessing files and redirecting System.err. I guess some of these might be 
useful enough to move to BaseTestCase for reuse in other tests, but I left them 
in ErrorStreamTest for the time being.

> Convert testing of derby error stream to JUnit
> ----------------------------------------------
>
>                 Key: DERBY-3156
>                 URL: https://issues.apache.org/jira/browse/DERBY-3156
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Vemund Østgaard
>            Assignee: Vemund Østgaard
>            Priority: Minor
>         Attachments: 3156-diff, 3156-diff.stat, 3156-diffv2, 3156-diffv2.stat
>
>
> Convert the tests that are related to derby error stream properties and 
> functionality.
> Seems to be these two tests:
> lang/logStream.java 
> lang/errorStream.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to