[ 
https://issues.apache.org/jira/browse/DERBY-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543010
 ] 

Jørgen Løland commented on DERBY-3189:
--------------------------------------

Thanks for the review and commit, Knut. 

I see your point in the exception/connection argument, although wrapping a 
ReplicationSuccessfullyStartedException in a LOGIN_FAILED SQLException sounds 
pretty strange. I'll leave it as is for now. Changing this to throw an 
exception instead of returning a connection at a later stage should be very 
easy.

I'm leaving this issue open until junit tests have been added.

> Replication: Add connection url command options for starting and stopping 
> master
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-3189
>                 URL: https://issues.apache.org/jira/browse/DERBY-3189
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: Jørgen Løland
>         Attachments: derby-3189-1a.diff, derby-3189-1a.stat
>
>
> Add commands to start and stop the replication master using properties or 
> connection url. Example:
> 'jdbc:derby:<host><masterdb>;startMaster=true';
> 'jdbc:derby:<host><masterdb>;stopMaster=true';
> Connection url options that must be recognized:
> startMaster=true
> stopMaster=true
> slaveHost=<host> (required)
> slavePort=<port> (optional, defaults to 8001)
> See functional specification on Derby-2872 for further details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to