[
https://issues.apache.org/jira/browse/DERBY-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545775
]
Knut Anders Hatlen commented on DERBY-3211:
-------------------------------------------
Hi Myrna,
I think this getAlternativePort() method attempts to do too much. I would
expect it just to return a port number, and that two subsequent calls would
return the same number. Starting the server in a getter method also feels a
little strange. I liked Manjula's approach with using NetworkServerTestSetup to
start and stop the server better, if only the port number was defined in
TestConfiguration instead of in the test itself.
If the alternative port is not available, I think it is OK that the test fails,
since that would be a problem with the environment, the same way as if the
default port was not available or the hard disk was full.
> Convert derbynet/NSinSameJVM.java to junit
> ------------------------------------------
>
> Key: DERBY-3211
> URL: https://issues.apache.org/jira/browse/DERBY-3211
> Project: Derby
> Issue Type: Test
> Reporter: Manjula Kutty
> Assignee: Manjula Kutty
> Priority: Minor
> Fix For: 10.3.1.5, 10.4.0.0
>
> Attachments: DERBY-3211_diff_11_16.txt, DERBY-3211_diff_11_19.txt,
> DERBY-3211_diff_11_19_ver2.txt, DERBY-3211_stat_11_16.txt,
> DERBY-3211_stat_11_19.txt, DERBY-3211_stat_11_19_ver2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
