[
https://issues.apache.org/jira/browse/DERBY-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549155
]
Mamta A. Satoor commented on DERBY-3037:
----------------------------------------
I committed a change(601830) into trunk with following commit comments
DERBY3037
This commit makes sure that EmbeddedResultSet.close() calls Language
Resultset.close rather than Language
Resultset.finish. This change caused few tests to fail. The tests had runtime
statistics on but the code to dump
the runtime statistics was in Language Resutlset.finish and not in Language
Resultset.close. To fix this, I have
moved the code to dump runtime statistics from Language Resutlset.finish into
Lanugage ResultSet.close This has
fixed the test failures.
As for the 2nd part of this jira entry which is to have activation.close() call
Language Resultset.finish(). This
already happens in impl.sql.execute.BaseActivation.close() and hence no work
was needed for the 2nd part.
Will merge this change into 10.3 codeline soon.
> Language ResultSet.finish() is called even when the ResultSet is going to be
> re-used.
> -------------------------------------------------------------------------------------
>
> Key: DERBY-3037
> URL: https://issues.apache.org/jira/browse/DERBY-3037
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.4.0.0
> Reporter: Daniel John Debrunner
> Assignee: Mamta A. Satoor
>
> DERBY-827 (correctly) changed the lifetime of the language ResultSet tree to
> be the lifetime of the activation, but did not fix up the correct calls to
> ResultSet.close() and ResultSet.finish().
> A language ResultSet's lifetime should be driven by the activation, so
> activation.close() should call finish() on its ResultSet.
> EmbedResultSet should call close on its language ResultSet (theResults field)
> when the JDBC ResultSet is closed, it should not be calling finish() on its
> ResultSet.
> See comments in DERBY-827 for some more details and issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
