[
https://issues.apache.org/jira/browse/DERBY-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553377
]
Knut Anders Hatlen commented on DERBY-3235:
-------------------------------------------
Hi, I noticed this diff in MasterFactory:
/**
* Will perform all work that is needed to shut down replication
+ *
+ * @throws StandardException Standard Derby exception policy,
+ * thrown on replication stop failure.
*/
public void stopMaster();
The javadoc says that an exception is thrown, whereas the signature doesn't.
The implementation in MasterController seems to log the exceptions instead of
throwing them, so perhaps the @throws tag should be removed?
> Implement the replication stop functionality
> --------------------------------------------
>
> Key: DERBY-3235
> URL: https://issues.apache.org/jira/browse/DERBY-3235
> Project: Derby
> Issue Type: Sub-task
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: StopImplementation_v1.diff, StopImplementation_v1.stat,
> StopImplementation_v1_NotForCommit.diff,
> StopImplementation_v1_NotForCommit.stat, StopImplementation_v2.diff,
> StopImplementation_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
