[
https://issues.apache.org/jira/browse/DERBY-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557293#action_12557293
]
Kristian Waagan commented on DERBY-3117:
----------------------------------------
Thanks for the useful plan summary Rick :)
With duplicate code, I was thinking on the following (taken from build.xml).
<target name="setInitialProperties" if="dontAutosetProps"
description="Set the initial properties for this build script. This
duplicates the property setting block in setCompilerProperties. Once we make
setCompilerProperties mandatory, this target should be removed."
and
<target name="setCompilerProperties" unless="dontAutosetProps"
description="Set the ant variables which identify the compiler
classpaths. Remove the autosetProps logic when this target becomes mandatory."
That said, maybe I was a bit to impatient.
I just thought that the PropertySetter is coded in such a way that there is no
longer any need for dontAutosetProps, since it will return without doing
anything it the java1Xcompile.classpath variables are set, and it will derive
them if the j1Xlib variables are set.
I'm current running with j4lib and j5lib in my ant.properties and it is working
fine.
Your plan makes sense to me.
> Adjust master build script to require the Java 5 compiler to build Derby
> ------------------------------------------------------------------------
>
> Key: DERBY-3117
> URL: https://issues.apache.org/jira/browse/DERBY-3117
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: BuildDefaults.txt, d3117-solaris.diff,
> derby-3117-01-enforceJava5-aa.diff, derby-3117-01-enforceJava5-ab.diff,
> derby-3117-01-enforceJava5-ac.diff, derby-3117-02-website-aa.diff,
> derby-3117-03-junit-aa.diff, derby-3117-04-propertySetter-aa.diff,
> derby-3117-04-propertySetter-ab.diff, derby-3117-04-propertySetter-ac.diff,
> derby-3117-04-propertySetter-ad.diff, derby-3117-04-propertySetter-ae.diff,
> derby-3117-04-propertySetter-af.diff, derby-3117-04-propertySetter-ag.diff,
> derby-3117-04-propertySetter-ah.diff, derby-3117-05-setterCleanup-aa.diff,
> derby-3117-06-setterDefault-aa.diff, derby-3117-07-buildInstructions-aa.diff,
> derby-3117-08a-j15libBuildingInstr.diff, derby_source.html
>
>
> Require the Java 5 compiler in order to build Derby as approved by the
> community recently:
> http://www.nabble.com/-VOTE--Require-Java-5-%28or-later%29-compiler-to-build-Derby-tf4522491.html#a13030783
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
