[
https://issues.apache.org/jira/browse/DERBY-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-3050:
-----------------------------------
Attachment: convertToJunit.diff
Attached is a new version of 'convertToJunit.diff'.
This version substantially revises GroupByTest.java
to address Manish's suggestions regarding test case
organization. I have broken the monolithic test case
generated by the conversion tool into a dozen sub-tests,
according to boundaries that seemed reasonable to me.
I also:
- consolidated all the table creation/population logic
into setUp() and the drop logic into tearDown()
- revised the existing test cases in GroupByTest to match
- removed the line which was setting autocommit to
false, and simply had all the tests run in autocommit mode.
The .stat file is unchanged; this patch deletes 4 files and modifies 2.
I'm still a beginner at this process of converting the old-style
IJ script tests to JUnit, so there are probably more things
I've missed. So, please have a look at this new patch and
provide more feedback!
> Convert groupBy.sql tests to JUnit and include them in GroupByTest.java
> -----------------------------------------------------------------------
>
> Key: DERBY-3050
> URL: https://issues.apache.org/jira/browse/DERBY-3050
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Bryan Pendleton
> Assignee: Bryan Pendleton
> Priority: Minor
> Attachments: convertToJunit.diff, convertToJUnit.diff,
> convertToJUnit.stat
>
>
> There are currently 3 sets of GROUP BY tests:
> - GroupByExpressionTest.java
> - GroupByTest.java
> - groupBy.sql
> The first two tests are JUnit tests; the groupBy.sql tests are old-style
> harness tests,
> although they are now run in the JUnit framework using the LangScripts
> technique.
> This sub-task proposes to convert the groupBy.sql tests to JUnit tests, and
> to include
> them directly into GroupByTest.java.
> The DERBY-2151 conversion tool can be used to assist in the conversion
> process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
