[
https://issues.apache.org/jira/browse/DERBY-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561670#action_12561670
]
Knut Anders Hatlen commented on DERBY-3308:
-------------------------------------------
The patch looks fine to me.
Since the list is now guarded by synchronization on the pooled connection,
couldn't it be changed from Vector to ArrayList? (Should be safe to do with
listeners_ in the parent class as well.)
> Broken synchronization for event handling in ClientPooledConnection40
> ---------------------------------------------------------------------
>
> Key: DERBY-3308
> URL: https://issues.apache.org/jira/browse/DERBY-3308
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.2.2.0, 10.3.2.1, 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3308-1a-eventlisteners_synchronization.diff
>
>
> Access to the the list of event listeners is not synchronized properly.
> Taken the rather infrequent use of the relevant methods and the small
> critical sections, I mean it is sufficient to add synchronization to all the
> methods that access it at the method level. The same approach is taken in
> ClientPooledConnection (although not followed through consistently, some of
> the methods are unsynchronized).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
