[
https://issues.apache.org/jira/browse/DERBY-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Myrna van Lunteren updated DERBY-3088:
--------------------------------------
Attachment: DERBY-3088_ServerPropertiesTest_3.diff
DERBY-3088_ServerPropertiesTest_3.stat
Attaching a patch that reworks the ServerPropertiesTest so the first fixture
uses NetworkServerTestSetup.
Reworked NetworkServerTestSetup; added some helper methods and reworked
pingForServerStart (to pingForServerUp) so that the method that pings has
intelligence about the expected outcome - if the server is expected up, it will
ping for a while until the ping is either successful, or timed out; if the
server is expected down, it will ping for a while until unsuccessful or timed
out. Also made it ping first, before sleeping.
Reworked Utilities.ExecJavaCmd to only return the Process; the caller then
needs to do the appropriate. Reason for this was that previously, if there was
a lot of data from pr.getInputStream, the method would hang itsefl on the
pr.waitFor().
This passed suites.All for me.
> convert to junit, or otherwise eliminate version in tests which require an
> update of the master in the release management process
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3088
> URL: https://issues.apache.org/jira/browse/DERBY-3088
> Project: Derby
> Issue Type: Improvement
> Components: Build tools, Test
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Attachments: DERBY-3088_ServerPropertiesTest.diff,
> DERBY-3088_ServerPropertiesTest2.diff,
> DERBY-3088_ServerPropertiesTest_3.diff, DERBY-3088_ServerPropertiesTest_3.stat
>
>
> There are a number of tests that require a master update every time the
> version number is bumped.
> This is a tedious and error prone detail in the release management process.
> Currently affected masters are listed in tools/release/build.xml:
> java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/odbc_metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/odbc_metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/NSinSameJVM.out
> java/testing/org/apache/derbyTesting/functionTests/master/checkToursDB.out
> java/testing/org/apache/derbyTesting/functionTests/master/testclientij.out
> java/testing/org/apache/derbyTesting/functionTests/master/testProperties.out
> It would streamline the release process if these tests in particular were
> either converted to junit, or if the version numbers would be eliminated.
> Note: there already is a bug for metadata.java conversion: DERBY-2242
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
