[ 
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566169#action_12566169
 ] 

Daniel John Debrunner commented on DERBY-3304:
----------------------------------------------

Thanks for the info about the moved code, I missed it in the jira comment.

I think the clearing of warnings on commit can go, as you say it's not required 
for a commit. I looked at it and think it has the potential to incorrectly 
clear warnings so that the application never sees them. I don't think there's a 
code path today that is subject to the bug, but one could appear in the future. 
So I'd say remove the clearing of warnings since it's not required and a no-op 
at the moment.

For the update conglomerate clearing, I think that's code that is in the wrong 
location, probably should be in the result set that set that field. That's 
probably a separate issue.

> Explicit commit inside a java procedure makes a dynamic result sets passed 
> out unavailable
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3304
>                 URL: https://issues.apache.org/jira/browse/DERBY-3304
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.4.0.0
>            Reporter: Daniel John Debrunner
>            Assignee: Mamta A. Satoor
>         Attachments: Main.java
>
>
> Repro (Main.java) that shows changed behavior after svn 602991
> (the patch committed for this issue). It seems a regression: (originally from 
> Dag H. Wanvik attached to DERBY-1585)
> An explicit commit inside a stored procedure makes a dynamic result sets 
> passed out unavailable, even if the commit is executed *prior* to the result 
> set; as in the repro.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to