[ 
https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ole Solberg updated DERBY-3163:
-------------------------------

    Attachment: derby-3163.1-v4.diff.txt
                derby-3163.2-v4.diff.txt

> 
> Is there a write up that explains what the changes are? Several of the new 
> methods in TestConfiguration have no comments so I have no idea what their 
> purpose is.

derby-3163.1-v4.diff.txt
------------------------
- TestConfiguration:
Add decorators which takes server host and port, for running tests in a 
server/client configuration, where a server has already 
been started on a that host and port.

- CleanDatabaseTestSetup:
Added a constructor which takes server host and port, for an already started 
server in a 
client/server configuration, to run the SQL decoration on that server.



Comments are now included for the added test decorators (plus for a couple of 
existing decorators
which also lacked comments.)


> 
> The switch to a static decorate() method in some of the tests is confusing. 
> Is there some explanation for why this is required, is this a pattern 
> required for all tests?
> 

derby-3163.2-v4.diff.txt
------------------------
- AnsiTrimTest, CreateTableFromQueryTest:
Factored out the SQL statement execution for database content setup to
be able to reuse the same code in other TestCases which add the same
test method in their 'suite()' method.
Currently this is done for a few testcases reused in replication testing:
o.a.dT.ft.tests.replicationTests.StandardTests: e.g. as 
'AnsiTrimTest.decorate(s);' (derby-3164.1)

This pattern is required for all tests which is to be used in other 
TestCases which add the same test method in their 'suite()' method.


> Derby JUnit test framework adaptions to run existing tests against replicated 
> databases
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-3163
>                 URL: https://issues.apache.org/jira/browse/DERBY-3163
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Ole Solberg
>            Assignee: Ole Solberg
>            Priority: Minor
>         Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, 
> derby-3163.1-v3.diff.txt, derby-3163.1-v4.diff.txt, derby-3163.2-v1.diff.txt, 
> derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt, derby-3163.2-v4.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests 
> ("derbyall" kind)
>   and junit tests)
>   This requires
>  - Running existing tests against already started servers on "non-localhost" 
> machines.
>  - verificationclients checking slave vs. master.
>  - ... 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to