[
https://issues.apache.org/jira/browse/DERBY-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2559:
-----------------------------------
Attachment: derby-2559-3b-documentation.diff
Thanks for looking at the patch Knut Anders.
'derby-2559-3b-documentation.diff' adds a throw clause to the JavaDoc and
corrects an invalid reference. I also refreshed the patch after applying patch
2a.
Committed 'derby-2559-2a-defenses.diff' to trunk with revision 628647.
Committed 'derby-2559-3b-documentation.diff' to trunk with revision 628654.
The previous code failed to create data sources when running with Java SE 6.
This suggest the patches could be backported to branches 10.2 and 10.3.
Patches 1 and 2 apply cleanly, the documentation patch (3) does not.
> recreating a datasource using javax.naming.Reference from a
> ClientDataSource40 fails
> ------------------------------------------------------------------------------------
>
> Key: DERBY-2559
> URL: https://issues.apache.org/jira/browse/DERBY-2559
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.3.1.4, 10.4.0.0
> Reporter: Myrna van Lunteren
> Assignee: Kristian Waagan
> Fix For: 10.4.0.0
>
> Attachments: derby-2559-1a.diff, derby-2559-2a-defenses.diff,
> derby-2559-3a-documentation.diff, derby-2559-3b-documentation.diff
>
>
> Consider the following code snippet from test DataSourceReferenceTest:
> --------------------
> Referenceable refDS = (Referenceable) ds;
> Reference dsAsReference = refDS.getReference();
> String factoryClassName = dsAsReference.getFactoryClassName();
> ObjectFactory factory =
> (ObjectFactory) Class.forName(factoryClassName).newInstance();
> Object recreatedDS =
> factory.getObjectInstance(dsAsReference, null, null, null);
> ---------------------
> When ds is a ClientDataSource40 (i.e. when running with jdk16), recreatedDS
> is null.
> Note, that this showed up only after converting the test to junit, because
> the original test hardcoded the ds to be a ClientDataSource. I confirmed this
> not to be related to my changes for DERBY-2296 (which prompted me to convert
> the test), by backing out my changes to ClientBaseDataSource and
> client/am/Connection and rerunning the test (needed some minor adjustments of
> expected values table/array).
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
