[
https://issues.apache.org/jira/browse/DERBY-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569922#action_12569922
]
Knut Anders Hatlen commented on DERBY-3192:
-------------------------------------------
I think the approach used in the patch looks fine, though I haven't
tested it yet. Please see my comments and questions below.
* DRDAConnThread.writePBSD() checks client type and version. It's
perhaps cleaner if we put the check in a method in AppRequester (for
instance, supportsPiggybackedSessionState).
* Is there any reason why the definition of the PiggyBackedSessionData
class is appended to Database.java rather than put in a separate
file? The class is not private to Database and keeping it there
might make it harder to find it.
* I think DRDAConnThread.trace() is normally only called when
SanityManager.DEBUG is true, but writePBSD() sometimes call it
regardless of the sanity setting.
* Could "catch (Throwable t) { t.printStackTrace(); }" be removed from
DRDAConnThread.writePBSD()?
* BrokeredConnection.getCurrentSchemaName() uses a mix of tabs and
spaces.
* EmbedConnection.getCurrentSchemaName() is declared as throws
SQLException, but I don't think any of the methods it calls throws
SQLException.
* The debug code at the end of DRDAConnThread.processCommands()
allocates and populates a Hashtable each time it is executed,
whereas it is only needed if an error has occurred. Perhaps it could
be allocated inside the if block and the catch block instead? Not a
big issue, though, since it's only in debug code. (This makes me
wish CodePointNameTable had static fields and methods, but that's
another patch in another JIRA issue...)
* NetStatementReply.parsePBSD() and
Connection/NetConnection.completePiggyBackSessionData() use an
Object array to represent the session state, and use the magic
numbers 0 and 1 to access the isolation level and the schema,
respectively. At a minimum, I think we should document in
Connection.completePiggyBackSessionData()'s javadoc comment what's
stored in each element of the array. It does however sound easier to
understand and maintain the code if we create a separate class to
hold this information. Or perhaps even simpler:
completePiggyBackSessionData() could take two arguments instead of a
two element array.
* In Connection.getTransactionIsolation(), I think the scope of the
isolation variable could be narrowed down a bit. I believe it could
be declared where it's assigned the first time, and the return
statement can be moved inside the try block.
> Cache session data in the client driver
> ---------------------------------------
>
> Key: DERBY-3192
> URL: https://issues.apache.org/jira/browse/DERBY-3192
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Network Client, Network Server, Performance, SQL
> Affects Versions: 10.3.1.4
> Reporter: Dyre Tjeldvoll
> Assignee: Dyre Tjeldvoll
> Attachments: derby-3192-mark2.v1.diff, derby-3192-mark2.v2.diff,
> derby-3192-mark2.v3.diff, derby-3192-test.fup1.diff,
> derby-3192-test.fup2.diff, derby-3192-test.v1.diff, derby-3192-test.v1.stat,
> derby-3192.prelim1.diff
>
>
> The reason for doing this is to avoid a rather
> substantial performance hit observed when the client driver is used
> together with an appserver that uses connection pooling. There are two
> problems:
> 1) The connection pool will compare the isolation level it has
> stored for the connection with the value returned from
> Connection.getTransactionIsolation() each and every time someone
> requests a new connection from the pool.
> 2) The users of the connection pool (ab)use it to avoid having to keep
> track of their current connection. So each time a query needs to be
> executed a call to the connection pool's getConnection() method is
> made. Getting a connection from the connection pool like this also
> means that a new PreparedStatement must be prepared each time.
> The net result is that each query results in the following sequence:
> getConnection()
> getTransactionIsolation() --> roundtrip + lookup in server's statement cache
> prepareStatment() --> roundtrip + lookup in server's statement cache
> executeQuery() --> roundtrip
> Arguably this is a "user error" but when suggesting this I'm kindly
> informed that this works "just fine" with other datbases (such as
> PostgreSQL and ORACLE).
> The reason why it works is that these databases do statement caching
> in the driver. I've tried to implement a very (too) simple statement
> cache in Derby's client driver and to re-enable caching of the
> isolation level (see
> https://issues.apache.org/jira/browse/DERBY-1148). With these changes
> I observe a marked performance improvement when running with appserver
> load.
> A proper statment cache cannot be implemented without knowing what the
> current schema is. If the current schema has changed since the
> statement was prepared, it is no longer valid and must be evicted from
> the cache.
> The problem with caching both the isolation level and the current schema in
> the driver is that both can change on the server without the client
> detecting it (through SQL and XA and possibly stored procedures).
> I think this problem can be overcome if we piggy-back the information we
> would
> like to cache on messages going back to the client. This can be done by
> utilizing the EXCSQLSET DRDA command. According to the DRDA spec (v4, volume
> 3,
> page 359-360) it is possible to add one or more SQLSTT objects after SQLCARD
> in the reply,
> I think it would be possible to cache additional session information when
> this becomes relevant. It
> would also be possible to use EXCSQLSET to batch session state changes
> going from the client to the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
