[
https://issues.apache.org/jira/browse/DERBY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570299#action_12570299
]
A B commented on DERBY-2653:
----------------------------
Thanks Kathey, this looks good to me.
Very minor nit:
int genKeys = (columnNames == null ||
(columnNames != null && columnNames.length == 0)
? Statement.NO_GENERATED_KEYS:
Statement.RETURN_GENERATED_KEYS);
I think that short-circuiting makes the "columnNames != null" check redundant
since if it's null, the OR will short-circuit and the right hand side won't
(shouldn't) ever get executed. So it could be simplified to:
int genKeys = (columnNames == null || columnNames.length == 0)
? Statement.NO_GENERATED_KEYS:
Statement.RETURN_GENERATED_KEYS);
But as I said, very minor :) Thanks for the additional test fixture, as well!
> Expose existing auto-generated key functionality through more JDBC APIs in
> Derby Client.
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2653
> URL: https://issues.apache.org/jira/browse/DERBY-2653
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Environment: Runnning with Derby Client.
> Reporter: A B
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-2653_columnNames2_diff.txt,
> derby-2653_columnNames_diff.txt, derby-2653_columnNames_diff.txt,
> derby-2653_proto_diff.txt
>
>
> See DERBY-2631 for details. Desired functionality is the same as for
> DERBY-2631, except that this issue is specifically for Derby Client
> (DERBY-2631 only addressed embedded mode).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
