[
https://issues.apache.org/jira/browse/DERBY-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-3438:
-----------------------------------
Attachment: derby-3438-1a-allow_sql_null.diff
'derby-3438-1a-allow_sql_null.diff' makes StatementKey capable of handling a
null SQL query text.
Patch ready for review.
> Allow SQL query text to be null in StatementKey
> -----------------------------------------------
>
> Key: DERBY-3438
> URL: https://issues.apache.org/jira/browse/DERBY-3438
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3438-1a-allow_sql_null.diff
>
>
> Because the SQL isn't checked before the cache is queried, StatementKey
> should allow the SQL query text to be null.
> This simplifies handling this exceptional situations, hopefully without
> complications.
> What will happen is, the cache is queried, null is returned (no match) and
> then prepare will fail in the driver. Because the statement is never
> prepared, it will never be inserted into the cached, nor (incorrectly)
> fetched from the cache in the first step.
> Of course, one could also explicitly check for null in either the
> Logical(Prepared|Callable)Statement[40], StatementKeyFactory or
> StatementCacheInteractor.
> However, the proposed change is small, isolated to one class and makes the
> exceptional case be handled by the normal code path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
