[ 
https://issues.apache.org/jira/browse/DERBY-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570765#action_12570765
 ] 

Daniel John Debrunner commented on DERBY-3435:
----------------------------------------------

Some potential javadoc improvements for NetworkServerMBean
  - add a package.html
  - Have the class javadoc define what type and other key properties are used 
(see the other MBeans)
  - Remove this vacuous sentence:
       This interface consists of getter and setter methods for attributes that 
may be read and/or modified, and methods representing operations that can be 
invoked.
      (it's adds no value, it's the definition of what an MBean is, it's like 
adding a comment to other classes "this interface consists of methods that can 
be called and fields that can be referenced").

  - Correct the comment for getDrdaHost related to 0.0.0.0, it indicates it 
affects which clients can connect, I think it means that the server listens on 
all network interfaces

  - For each attribute getXXX method add a summary of what the property does, 
just saying it gets derby.drda.XXX doesn't really help much.

  - Make the first javadoc sentence of the getXXX methods be the (English) 
summary of what the attribute represents and not just that it maps to 
derby.drda.XXX. This means the class summary in javadoc becomes more useful, 
e.g.
 
           Gets the host name for the network server

       instead of the current

            Gets the value of the derby.drda.host network server setting.
     

> Add an MBean for monitoring and managing the Network Server
> -----------------------------------------------------------
>
>                 Key: DERBY-3435
>                 URL: https://issues.apache.org/jira/browse/DERBY-3435
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server, Services
>            Reporter: John H. Embretsen
>            Assignee: John H. Embretsen
>         Attachments: d3435_v01.diff, d3435_v01.stat
>
>
> Most functionality of and information about a running instance of the Network 
> Server is currently only available from the host running the Network Server, 
> using the NetworkServerControl API.
> With a JMX Management and Monitoring service in place utilizing JMX 
> (DERBY-1387), it is possible to expose some of the Network Server 
> functionality and information through an MBean that is specific to the 
> Network Server, to both local and remote users (JMX clients), subject to 
> security restrictions. Access to Derby libraries on the client side is not 
> even a requirement, potentially making a server administrator's job a lot 
> easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to