[
https://issues.apache.org/jira/browse/DERBY-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571436#action_12571436
]
Øystein Grøvlen commented on DERBY-3205:
----------------------------------------
Thanks for the failover patch for slave, Jørgen. It looks good to me,
but I have not had a chance to try it out yet. My only concern from
reading the code is whether there a scenarios where we get into a
situation where the master fails and the slave refuses to do failover.
As far as I can tell, the only way the slave will recognize that the
connection with the master is lost is if the LogReceiver gets a
EOFException. Are you sure that covers all the situations where the
master fails?
A minor issue: I do not quite understand the comment for "if
(isFailoverMasterBoot)". Are you saying this must happen after
startTransaction in order for authentication/authorization to happen
first?
> Replication: Add connection url command options for starting, stopping slave
> and for failover
> ---------------------------------------------------------------------------------------------
>
> Key: DERBY-3205
> URL: https://issues.apache.org/jira/browse/DERBY-3205
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Affects Versions: 10.4.0.0
> Reporter: Jørgen Løland
> Assignee: Jørgen Løland
> Attachments: derby-3205_startslave_dontcommit.diff,
> derby-3205_startslave_dontcommit.stat, failover-slave-1a.diff,
> failover-slave-1a.stat, failover_impl_3205_NotForCommit_v1.diff,
> failover_impl_3205_NotForCommit_v1.stat, failover_impl_3205_v1.diff,
> failover_impl_3205_v1.stat, failover_impl_3205_v2.diff,
> failover_impl_3205_v2.stat, failover_impl_3205_v3.diff,
> failover_impl_3205_v3.stat, failover_impl_3205_v4.diff,
> failover_impl_3205_v4.stat, Socket_Close_Fix_v1.diff,
> Socket_Close_Fix_v1.stat, startSlave_1a.diff, startSlave_1a.stat,
> startSlave_1b.diff, startSlave_1b.stat, startSlave_1c.diff,
> startSlave_1d.diff, StopSlave_impl_3205_NotForCommit_v1.diff,
> StopSlave_impl_3205_NotForCommit_v1.stat, stopSlave_v1a.diff,
> stopSlave_v1a.stat, stopSlave_v1b.diff, stopSlave_v1b.stat,
> stopSlave_v1c.diff, stopSlave_v1c.stat
>
>
> Add commands to start and stop the replication slave using properties or
> connection url. Example:
> 'jdbc:derby:<host><dbname>;startSlave=true';
> 'jdbc:derby:<host><dbname>;stopSlave=true';
> 'jdbc:derby:<host><dbname>;failover=true;
> Connection url options that must be recognized:
> startSlave=true
> stopSlave=true
> failover=true
> slaveHost=<host> (optional, defaults to localhost) (only for startSlave)
> slavePort=<port> (optional, defaults to 8001) (only for startSlave)
> See functional specification on Derby-2872 for further details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
