[ 
https://issues.apache.org/jira/browse/DERBY-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571698#action_12571698
 ] 

Daniel John Debrunner commented on DERBY-3451:
----------------------------------------------

FYI on the patch format, I can get it to apply  almost (I use Eclipse) but 
require an extra step. Doing nothing the patch appears to be against files
   
   a/java/...

so I can ignore 1 segment in the file and then it seems ok, though this patch 
did not apply cleanly, not sure if it depends on another patch or not.

svn diff produces the expected format for patches. That format also includes 
the revision the patch is against, which allows anyone applying the patch to 
set their codeline to the same revision if they have problems applying it.

I would recommend using svn diff to make it easier for committers (and others) 
to try out & commit patches.

> Remove dependency between StandardException class and 
> org.apache.derby.impl.jdbc classes.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-3451
>                 URL: https://issues.apache.org/jira/browse/DERBY-3451
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: Dibyendu Majumdar
>            Assignee: Dibyendu Majumdar
>         Attachments: DERBY-3451_patch_1.txt
>
>
> In the package org.apache.derby.iapi.error, the class StandardException 
> contains references to following classes:
> org.apache.derby.impl.jdbc.Util
> org.apache.derby.impl.jdbc.EmbedSQLException
> This is undesirable as it introduces a dependency between StandardException 
> and the implementation of EmbedSQLException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to