[
https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-3326:
-----------------------------------
Attachment: derby-3326-7a-prepare_column_indexes_names_fix.diff
'derby-3326-7a-prepare_column_indexes_names_fix.diff' fixes bug where
statements prepared with prepareStatement(String,String[]|int[]) were always
prepared with Statement.RETURN_GENERATED_KEYS.
The code now checks if the arrays are null or empty.
There is a related problem when the array has more than one element. The client
driver currently doesn't throw an exception, and the assert kicks in (see
CachingLogicalConnection). I haven't decided what to do with this. The easiest
is probably to ignore this fact and collapse the if to handle only the
null/empty case and the not-empty case.
Comments?
Patch ready for review.
> Introduce a caching logical connection and logical prepared statement in the
> client driver
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-3326
> URL: https://issues.apache.org/jira/browse/DERBY-3326
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC, Network Client
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Fix For: 10.4.0.0
>
> Attachments: derby-3326-1a_cpds_testing_preparation.diff,
> derby-3326-1a_cpds_testing_preparation.stat,
> derby-3326-1b_cpds_testing_preparation.diff,
> derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff,
> derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff,
> derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff,
> derby-3326-4a-cpdsc_shutEngine.diff,
> derby-3326-5a-enable_logicalstmtentity_pptest.diff,
> derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff,
> derby-3326-7a-prepare_column_indexes_names_fix.diff
>
>
> A logical connection with statement caching capabilities is required to
> support JDBC prepared statement pooling. Further, a logical prepared
> statement object is also needed.
> The logical prepared statements will be generated by the logical connection's
> 'prepareStatement'-method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
