[
https://issues.apache.org/jira/browse/DERBY-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572588#action_12572588
]
Daniel John Debrunner commented on DERBY-3441:
----------------------------------------------
I think a list of what is being reset in resetForReuse()'s javadoc (for the
method) would be very useful. Otherwise one has to "slug" through the
code figuring out what is being reset.
A comment to explain this code would be really good:
+ } catch (SqlException sqle) {
+ throw sqle.getSQLException();
+ }
Ie. why is the top-level exception not being thrown.
Minor improvement in resetParameters()
+ for (int i = 0; i < parameterMetaData_.columns_; i++) {
+ parameters_[i] = null;
+ parameterSet_[i] = false;
+ parameterRegistered_[i] = false;
+ }
would be to use Arrays.fill().
> Determine and implement a proper procedure for resetting a prepared statement
> for reuse in a statement pool
> -----------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3441
> URL: https://issues.apache.org/jira/browse/DERBY-3441
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC, Network Client
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Fix For: 10.4.0.0
>
> Attachments: derby-3441-1a-statement_reset.diff
>
>
> Initial investigations indicate there are no existing suitable methods to
> properly reset a prepared (or callable) statement for reuse with a statement
> pool.
> A full reset is too heavy weight and defeats the purpose of statement
> pooling, but a proper procedure should be achievable by reusing existing
> pieces of code.
> Correctness is of course the most important thing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
