[
https://issues.apache.org/jira/browse/DERBY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zaun updated DERBY-2109:
-------------------------------
Attachment: DERBY-2109-12.diff
DERBY-2109-12.stat
Please find attached for review and testing the updated patch DERBY-2109-12,
which addresses the J2ME/CDC failures with former patches. Patch #12 passes
junit-all on my machine (and I'll run derbyall later tonight).
Myrna, thanks for testing on J2ME/CDC. It would be great if you could run the
latest patch #12 too.
I've applied the code refactorizations along the lines Dan's suggested:
a) InternalDriver now has a new method:
abstract public void checkSystemPrivileges(String user, Permission perm)
throws Exception;
which is implemented in Driver20 with a call to SecurityUtil, and in
Driver169 as an empty method body (with a comment).
b) SecurityUtil has been stripped off knowledge of SystemPermission,
DatabasePermission (but continues to deal with Subjects, Principals,
Authorization Ids, and executing the permission checks).
c) InternalDriver, EmbedConnection have methods
public void checkShutdownPrivileges(String user) throws SQLException
public void checkDatabaseCreatePrivileges(String user, String dbname)
throws SQLException
both of them calling the driver's (abstract) checkSystemPrivileges().
d) NetworkServerControlImpl's method
public void checkShutdownPrivileges() throws SQLException
calls static SecurityUtil.checkUserHasPermission(). There may be an option
to change that call to InternalDriver's checkSystemPrivileges(), but so far (by
design, I guess), NetworkServerControl only knows of Driver, not InternalDriver.
Martin
> System privileges
> -----------------
>
> Key: DERBY-2109
> URL: https://issues.apache.org/jira/browse/DERBY-2109
> Project: Derby
> Issue Type: New Feature
> Components: Security
> Affects Versions: 10.3.1.4
> Reporter: Rick Hillegas
> Assignee: Martin Zaun
> Attachments: DERBY-2109-02.diff, DERBY-2109-02.stat,
> derby-2109-03-javadoc-see-tags.diff, DERBY-2109-04.diff, DERBY-2109-04.stat,
> DERBY-2109-05and06.diff, DERBY-2109-05and06.stat, DERBY-2109-07.diff,
> DERBY-2109-07.stat, DERBY-2109-08.diff, DERBY-2109-08.stat,
> DERBY-2109-08_addendum.diff, DERBY-2109-08_addendum.stat, DERBY-2109-09.diff,
> DERBY-2109-09.stat, DERBY-2109-10.diff, DERBY-2109-10.stat,
> DERBY-2109-11.diff, DERBY-2109-11.stat, DERBY-2109-12.diff,
> DERBY-2109-12.stat, SystemPrivilegesBehaviour.html, systemPrivs.html,
> systemPrivs.html, systemPrivs.html, systemPrivs.html
>
>
> Add mechanisms for controlling system-level privileges in Derby. See the
> related email discussion at
> http://article.gmane.org/gmane.comp.apache.db.derby.devel/33151.
> The 10.2 GRANT/REVOKE work was a big step forward in making Derby more
> secure in a client/server configuration. I'd like to plug more client/server
> security holes in 10.3. In particular, I'd like to focus on authorization
> issues which the ANSI spec doesn't address.
> Here are the important issues which came out of the email discussion.
> Missing privileges that are above the level of a single database:
> - Create Database
> - Shutdown all databases
> - Shutdown System
> Missing privileges specific to a particular database:
> - Shutdown that Database
> - Encrypt that database
> - Upgrade database
> - Create (in that Database) Java Plugins (currently Functions/Procedures,
> but someday Aggregates and VTIs)
> Note that 10.2 gave us GRANT/REVOKE control over the following
> database-specific issues, via granting execute privilege to system
> procedures:
> Jar Handling
> Backup Routines
> Admin Routines
> Import/Export
> Property Handling
> Check Table
> In addition, since 10.0, the privilege of connecting to a database has been
> controlled by two properties (derby.database.fullAccessUsers and
> derby.database.defaultConnectionMode) as described in the security section of
> the Developer's Guide (see
> http://db.apache.org/derby/docs/10.2/devguide/cdevcsecure865818.html).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
