[ 
https://issues.apache.org/jira/browse/DERBY-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573940#action_12573940
 ] 

Daniel John Debrunner commented on DERBY-3435:
----------------------------------------------

Nice addition Bernt, can I suggest a few attribute name changes:

ActiveSessions, WaitingSessions and ConnectionTheads all represent counts or 
number of of items but it's not clear from their names.
One might imagine an MBean attribute that did return a information about the 
set of active sessions which would naturally be called ActiveSessions.

How about

ActiveSessionCount

or

NumberOfActiveSessions

(etc.)

I prefer the Count at the end, as then it's quicker when seeing the method name 
to determine what it is about, rather than having to mentally parse 'NumberOf'.

--------------------------

NumberOfConnections is as you say the number of accepted connections, but its 
name does not imply that. When just running the MBean I'd assumed it meant the 
number of current connections.

(and of course if the attribute names are change the style should be consistent 
across the Mbean and all of derby's MBeans)

> Add an MBean for monitoring and managing the Network Server
> -----------------------------------------------------------
>
>                 Key: DERBY-3435
>                 URL: https://issues.apache.org/jira/browse/DERBY-3435
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JMX
>            Reporter: John H. Embretsen
>            Assignee: John H. Embretsen
>             Fix For: 10.4.0.0
>
>         Attachments: d3435_v01.diff, d3435_v01.stat, 
> derby-3435-live-data-v0.diff, derby-3435-live-data-v0.stat, 
> derby-3435-live-data-v1.zip, derby-3435-live-data-v2.zip
>
>
> Most functionality of and information about a running instance of the Network 
> Server is currently only available from the host running the Network Server, 
> using the NetworkServerControl API.
> With a JMX Management and Monitoring service in place utilizing JMX 
> (DERBY-1387), it is possible to expose some of the Network Server 
> functionality and information through an MBean that is specific to the 
> Network Server, to both local and remote users (JMX clients), subject to 
> security restrictions. Access to Derby libraries on the client side is not 
> even a requirement, potentially making a server administrator's job a lot 
> easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to