[ 
https://issues.apache.org/jira/browse/DERBY-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Serge Tsv updated DERBY-3437:
-----------------------------

    Attachment: DERBY-3437-1.stat
                DERBY-3437-1.diff

Hello!

Øystein, you're right, the patch was relative to a trunk/java folder. I've 
attached a patch against a latest trunk revision relative to a trunk folder now 
which incorporates changes introduced in the previous patch and also a naming 
for an async log shipper thread.

Below is a list of modified files with short explanations.

M 
java/engine/org/apache/derby/impl/services/replication/slave/SlaveController.java

* Have added a package-protected non-arg constructor to an inner 
SlaveLogReceiverThread class, with a call to Thread constructor with a name 
parameter.

M 
java/engine/org/apache/derby/impl/services/replication/master/MasterController.java

* Have created a new package-protected method "getDbName" now used by 
AsynchronousLogShipper to name a log shipper thread.

M 
java/engine/org/apache/derby/impl/services/replication/master/AsynchronousLogShipper.java

* Have added a call to the Thread constructor with a thread name parameter.

M java/engine/org/apache/derby/impl/db/SlaveDatabase.java

* Have added an additional name parameter to a Thread construtor creating a 
slave database boot thread.

Have tested it, everything seems to work fine.

The following is an example of replication thread names:

  - derby.slave.boot-localdb_slave
  - derby.slave.logger-localdb_slave
  - derby.master.logger-localdb

Thanks!

> Give all replication threads meaningfull names
> ----------------------------------------------
>
>                 Key: DERBY-3437
>                 URL: https://issues.apache.org/jira/browse/DERBY-3437
>             Project: Derby
>          Issue Type: Improvement
>          Components: Newcomer, Replication
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: Serge Tsv
>            Priority: Minor
>         Attachments: DERBY-3437-1.diff, DERBY-3437-1.stat, DERBY-3437.diff
>
>
> Some threads are created for replication purposes:
> * The log shipper thread on the master 
> (o.a.d.i.services.master.MasterController)
> * The database boot thread on the slave (o.a.d.i.db.SlaveDatabase)
> * The log receiver thread on the slave 
> (o.a.d.i.services.slave.SlaveController)
> These threads should be given names to simplify debugging.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to