[
https://issues.apache.org/jira/browse/DERBY-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574756#action_12574756
]
thomanie edited comment on DERBY-2998 at 3/3/08 1:54 PM:
---------------------------------------------------------------
I was looking into why the distinct issue happened tonight and decided to fix
it.
Attaching 'd2998-followup-distinct.diff' that solves this for both queries and
subqueries, as well as adding a couple of DISTINCT queries to OLAPTest.
The updated OLAPTest pass.
The proposed change in ProjectRestrictNode.java isn't perfect. I had to use a
boolean variable to trigger VCN regeneration to avoid getting a nasty
if-instanceof construct. It might just be too late in the day...
When the distinct issue is fixed the ArrayIndexOutOfBoundsException Army
reported is avoided since RealDistinctScanStatistics is not used. I'll remove
the patch I uploaded earlier today.
was (Author: thomanie):
I was looking into why the distinct issue tonight and decided to fix it.
Attaching 'd2998-followup-distinct.diff' that solves this for both queries and
subqueries, as well as adding a couple of DISTINCT queries to OLAPTest.
The updated OLAPTest pass.
The proposed change in ProjectRestrictNode.java isn't perfect. I had to use a
boolean variable to trigger VCN regeneration to avoid getting a nasty
if-instanceof construct. It might just be too late in the day...
When the distinct issue is fixed the ArrayOutOfBoundsException Army reported is
avoided since RealDistinctScanResultSet is not used. I'll remove the patch I
uploaded earlier today.
> Add support for ROW_NUMBER() window function
> --------------------------------------------
>
> Key: DERBY-2998
> URL: https://issues.apache.org/jira/browse/DERBY-2998
> Project: Derby
> Issue Type: Sub-task
> Components: SQL
> Reporter: Thomas Nielsen
> Assignee: Thomas Nielsen
> Priority: Minor
> Attachments: d2998-10.diff, d2998-10.stat, d2998-11.diff,
> d2998-12.diff, d2998-12.stat, d2998-13.diff, d2998-13.stat, d2998-14.diff,
> d2998-14.stat, d2998-15.diff, d2998-15.stat, d2998-16.diff, d2998-16.stat,
> d2998-17.diff, d2998-17.stat, d2998-18.diff, d2998-18.stat, d2998-19.diff,
> d2998-19.stat, d2998-4.diff, d2998-4.stat, d2998-5.diff, d2998-5.stat,
> d2998-6.diff, d2998-6.stat, d2998-7.diff, d2998-7.stat, d2998-8.diff,
> d2998-8.stat, d2998-9-derby.log, d2998-9.diff, d2998-9.stat,
> d2998-doc-1.diff, d2998-doc-1.stat, d2998-doc-2.diff, d2998-doc-2.stat,
> d2998-followup-2.diff, d2998-followup-2.stat, d2998-followup-distinct.diff,
> d2998-followup-distinct.stat, d2998-followup-issue1.diff,
> d2998-followup-issue1.stat, d2998-followup-issue4.diff,
> d2998-followup-issue4.stat, d2998-followup-testsuite.diff,
> d2998-followup-testsuite.stat, d2998-test.diff, d2998-test.stat,
> d2998-test2.diff, d2998-test2.stat, d2998-test3.diff, d2998-test3.stat,
> d2998-test4.diff, d2998-test4.stat, d2998-test6.diff, d2998-test7.diff,
> d2998-test8.diff, d2998-test9.diff
>
>
> As part of implementing the overall OLAP Operations features of SQL
> (DERBY-581), implement the ROW_NUMBER() window function.
> More information about this feature is available at
> http://wiki.apache.org/db-derby/OLAPRowNumber
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
