[
https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574900#action_12574900
]
Øystein Grøvlen commented on DERBY-3162:
----------------------------------------
Ole, thanks for the follow-up patch. I have some comments:
* ReplicationRun#startServer_direct: You have several attempts to set
the same properties. I think that is a bit confusing to the
reader.
* ReplicationRun_Full:
- suite() does addTestSuite(ReplicationRun.class). Is that the
right class? (Trying to run the class indicates that it is not.)
- Lots of unecessary imports. Only the junit packages seems to be
needed.
- No need to override setUp and tearDown when they only call the
overridden method.
> Create a framework for replication tests
> ----------------------------------------
>
> Key: DERBY-3162
> URL: https://issues.apache.org/jira/browse/DERBY-3162
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt,
> derby-3162.2-v2.stat.txt, derby-3162.3-v1.diff.txt, derby-3162.3-v1.stat.txt,
> derby-3162.3-v2.diff.txt, derby-3162.3-v2.stat.txt
>
>
> Handle
> - starting and stopping Derby servers to have the master and slave
> replication roles,
> - doing administrative commands like startreplication, startslave,
> stopreplication, failover,
> - performing consistency checks on the slave vs. the master,
> - running load clients against master and slave in the various states of
> replication,
> - provoking error situations on master and slave, and network,
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
