[ 
https://issues.apache.org/jira/browse/DERBY-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anurag Shekhar updated DERBY-3330:
----------------------------------

    Attachment: derby-3330_followup_1.diff

Issues addressed in derby-3330_followup_1.diff

CreateIndexConstantAction.java 

I have changed the name of the variable and added comment to explain what its 
meant for.
I got confused while commenting last time. This property is required if 
TransactionCoordinator has to select the non default Sorter.

sort changes

I have updated compare method and it doesn't need to assume location column. 
But it still
has information about nulls not being equal. 
I am checking how to remove this information from comparison. It appears to me 
that I can remove 
this custom compare method and use the existing but that miy need some change 
which might effect 
other part of code.I will wait for 10.4 branching and will work for it in the 
trunk.



BTreeController.java

I haven't optimized it yet. But instead of returning error code setting the ret 
value so the latch 
is cleared before return.


IndexDescriptorImpl.java

Updated both the place (using new name in toString () and using the new 
attribute in equals methods).

BTreeController.java
I am still checking it out and will submit new follow up if I find any problem 
areas.

junit suites.All is running without any failure with this patch.

> provide support for unique constraint over keys that include one or more 
> nullable columns.
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3330
>                 URL: https://issues.apache.org/jira/browse/DERBY-3330
>             Project: Derby
>          Issue Type: New Feature
>          Components: Store
>    Affects Versions: 10.4.0.0
>         Environment: all
>            Reporter: Anurag Shekhar
>            Assignee: Anurag Shekhar
>         Attachments: BTreeController.diff, db2Compatibility-v2.diff, 
> db2Compatibility.diff, derby-3330-testcase.diff, 
> derby-3330-UpgradeTests.diff, derby-3330.diff, derby-3330_followup_1.diff, 
> derby-3330v10.diff, derby-3330v11.diff, derby-3330v12.diff, 
> derby-3330v13.diff, derby-3330v2.diff, derby-3330v3.diff, derby-3330v4.diff, 
> derby-3330v5.diff, derby-3330v6.diff, derby-3330v7.diff, derby-3330v8.diff, 
> derby-3330v9.diff, derbyall_report.txt, FunctionalSpec_DERBY-3330-V2.html, 
> FunctionalSpec_DERBY-3330.html, UniqueConstraint_Implementation.html, 
> UniqueConstraint_Implementation_V2.html, 
> UniqueConstraint_Implementation_V3.html
>
>
> Allow unique constraint over keys which include one or more nullable fields.  
> Prior to this change Derby only supported unique constraints on keys that 
> included no nullable columns.  The new constraint will allow unlimited 
> inserts of any key with one more null columns, but will limit insert of keys 
> with no null columns to 1 unique value per table.
> There is no change to existing or newly created unique indexes on null 
> columns (as opposed to unique constraints on null columns).  Also there is no 
> change to existing or newly created constraints on keys with no nullable 
> columns.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to