[ 
https://issues.apache.org/jira/browse/DERBY-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jørgen Løland updated DERBY-3432:
---------------------------------

    Attachment: derby-3432-1a.diff
                derby-3432-1a.stat

The attached patch moves the replication class files from services to store. I 
tried to apply the patch using these commands:

svn move java/engine/org/apache/derby/impl/services/replication 
java/engine/org/apache/derby/impl/store/replication 

svn move java/engine/org/apache/derby/iapi/services/replication 
java/engine/org/apache/derby/iapi/store/replication 

gpatch -p0 <derby-3432-1a.diff 
(you need to hit 'n' multiple times to not revert deleting the files in the old 
location; not sure how to remove this - it's quite annoying)

In my sandbox, the *files* are removed from the old locations whereas the 
*directories* are not deleted. Not sure how to fix this either. However, I did 
try to run replication on a clean sandbox after applying the steps above. That 
works fine. I'm starting the tests now.

> Move replication code from org.apache.derby.impl.services.replication to 
> o.a.d.i.store.replication
> --------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3432
>                 URL: https://issues.apache.org/jira/browse/DERBY-3432
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous, Replication
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-3432-1a.diff, derby-3432-1a.stat
>
>
> The replication source code is currently in package 
> org.apache.derby.{impl|iapi}.services.replication, but the services package 
> is intended for low-level self-contained modules. Since the replication code 
> is highly integrated with the store modules, the replication code should be 
> moved to org.apache.derby.{impl|iapi}.store.replication.
> See discussion in mail-thread: 
> http://www.nabble.com/Opinions-please---some-questions-regarding-replication-td15452929.html#a15452929

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to