[ 
https://issues.apache.org/jira/browse/DERBY-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578385#action_12578385
 ] 

Kathey Marsden commented on DERBY-3523:
---------------------------------------

Thank you for the patch.  It looks good to me except I am a bit unsure about 
the new method in StandardException.  It seems specialized for the single 
argument case and a little out of place.  I think I would rather see the logic 
in the calling code, but I realize this was discussed earlier and perhaps this 
was the consensus that was reached.  If I am the only one that is uncomfortable 
with it I will go ahead and commit the patch as is tomorrow.

Should we have tests for the soft upgrade case?

Kathey


> sql states (X0Y63, X0Y63, X0Y63.S) related to nulls in unique constraints are 
> associated with wrong message texts 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3523
>                 URL: https://issues.apache.org/jira/browse/DERBY-3523
>             Project: Derby
>          Issue Type: Bug
>    Affects Versions: 10.4.0.0, 10.5.0.0
>            Reporter: Anurag Shekhar
>            Assignee: Anurag Shekhar
>         Attachments: derby-3523v1.diff, derby-3523v2.diff
>
>
> There are three messages which after Derby-3330 checkin now giving wrong 
> information. These are
> 42831:'{0}' cannot be a column of a primary key or unique key because it can 
> contain null values.
> 42Z20:Column '{0}' cannot be made nullable. It is part of a primary key or 
> unique constraint, which cannot have any null able columns.
> X0Y63.S:The command on table '{0}' failed because null data was found in the 
> primary key or unique constraint/index column(s). All columns in a primary or 
> unique index key must not be null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to