[
https://issues.apache.org/jira/browse/DERBY-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587604#action_12587604
]
Kristian Waagan commented on DERBY-3574:
----------------------------------------
Hi Tiago,
I haven't looked at the code changes in detail, but I did take a quick look at
the uploaded patches.
You are of course free to upload one patch per file, but I find it easier to
apply fixes when there is only one diff per "change iteration" / chunk of work.
Also, I believe the usual pattern is to generate the diffs from the within the
trunk directory so that you can apply the patch using "patch -p0 < patch.diff"
from the root directory (i.e. the path / context in the diff would be
"java/client/org/apache/...").
A few suggestions;
* use JavaDoc instead of normal comments for instance variables
* avoid whitespace changes and trailing whitespace (see for instance the patch
for Connection)
* avoid mixing tabs and spaces for indentation
A committer might still commit the patch even if these guidelines aren't
followed, but following them tends to speed up the review and commit process.
Thank you for your time and contribution :)
> With client, attempting to get the lob length after commit or connection
> close if there was a call to length() before commit does not throw an
> exception
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3574
> URL: https://issues.apache.org/jira/browse/DERBY-3574
> Project: Derby
> Issue Type: Bug
> Components: JDBC, Network Client, Newcomer
> Affects Versions: 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Tiago R. Espinha
> Priority: Trivial
> Attachments: derby3574-blob-java.patch, derby3574-clob-java.patch,
> derby3574-connection-java.patch, derby3574-lob-java.patch, TestLobLength.java
>
>
> Attempting to get call Blob/Clob.length() after commit or connection close
> does not fail if there was a previous call to length(). If no previous call
> was made an exception is thrown as expected.
> See attached program TestLobLength for repro with commit. If you comment out
> the two lines to get the length before the commit we get the expected
> exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
