[
https://issues.apache.org/jira/browse/DERBY-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589517#action_12589517
]
John H. Embretsen commented on DERBY-3588:
------------------------------------------
Seems like a sound change to me.
I am running tests with a modified version of the patch
'BuildOn1.5_jdbc4._Suite_alt2.diff.txt', having added the words "Class not
found: " to the skip message since the exception message of
ClassNotFoundException usually is the class name, not what kind of exception it
is. Makes it easier to spot why the suite was skipped when running with certain
test runners.
+ } catch (ClassNotFoundException ce) { // Do not add a suite not built.
+ return new TestSuite("SKIPPED: Class not found: " + className +
+ " - " + ce.getMessage());
I intend to commit the patch if my test results are OK. However, I do think the
failures Ole saw when running tests built with 1.5 using a 1.6 VM should be
investigated further.
> suites.All fails to run on Jvm 1.5 when built with JDK 1.5 (Failed to invoke
> suite(): .jdbc4._Suite)
> ----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3588
> URL: https://issues.apache.org/jira/browse/DERBY-3588
> Project: Derby
> Issue Type: Bug
> Components: Regression Test Failure, Test
> Affects Versions: 10.4.1.0, 10.5.0.0
> Environment: Building with JDK 1.5 (
> 'j15lib=/usr/local/java/jdk1.5/jre/lib'.)
> Running tests with
> JVM:
> Sun Microsystems Inc.
> java version "1.5.0_14"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_14-b03)
> Java HotSpot(TM) Client VM (build 1.5.0_14-b03, mixed mode)
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Attachments: BuildOn1.5_jdbc4._Suite_alt2.diff.txt,
> suites.All_BuiltW15RunOn1.6.txt
>
>
> I discovered that since svn r633968 - 2008-03-05 19:45:52 CET, .suites.All
> has failed with
> 'Failed to invoke suite():java.lang.ClassNotFoundException:
> org.apache.derbyTesting.functionTests.tests.jdbc4._Suite' in my test runs
> where I have built with JDK 1.5, i.e. have
> 'j15lib=/usr/local/java/jdk1.5/jre/lib' in ~/ant.properties.
> I think this is related to svn r633658 which removed the test for
> 'JDBC.vmSupportsJDBC4()' when doing
> 'suite.addTest(addSuiteByReflection("org.apache.derbyTesting.functionTests.tests.jdbc4._Suite"));'.
> I added the 'if (JDBC.vmSupportsJDBC4()){....}' again and am now runnning
> .suites.All on one of my 1.5 test platforms.
> An alternative might be to catch 'ClassNotFoundException' in
> 'addSuiteByReflection()'?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
