[
https://issues.apache.org/jira/browse/DERBY-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600463#action_12600463
]
V.Narayanan commented on DERBY-2514:
------------------------------------
I think Knut has some very valid points, sorry for my overlooking those
important points in my review Svien Erik,
I understand it can be frustrating receiving multiple comments and redoing the
patch initially. But I think
your patch looked really good and knut's comments are mostly minor changes that
need some code moving, and a commit
on the issue is very close.
Thank you for the effort and the quick response to my earlier comments.
> convert lang/closed.java to junit
> ---------------------------------
>
> Key: DERBY-2514
> URL: https://issues.apache.org/jira/browse/DERBY-2514
> Project: Derby
> Issue Type: Test
> Components: Newcomer, Test
> Environment: convert lang/closed.java to junit
> Reporter: Ramandeep Kaur
> Assignee: Svein Erik Løvland
> Priority: Minor
> Attachments: Derby2514.diff, Derby2514_2.diff, Derby2514_3.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.