[
https://issues.apache.org/jira/browse/DERBY-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dag H. Wanvik updated DERBY-3722:
---------------------------------
Attachment: derby-3722-2.stat
derby-3722-2.diff
Thanks for looking at this, Kristian!
A new version of the patch, derby-3722-2, addresses your comments:
1) Blank/tabs mix fixed.
2) Added JavaDoc for checkCircularity.
3) Typo fixed
4) Added more comments to checkGrantCircularity
5) Fixed typo: in->on
6) Fixed &kt -> <
7) Unused imports.
8) Made 'inverse' final.
9) Fixed '('
10) Removed 'grantor' from checkCircularity,
I also improved some javadoc in RoleClosureIteratorImpl.
The first patch passed the regression tests, so I expect this one to
pass as well. Re-running now.
> Add circularity check for the GRANT role statement
> --------------------------------------------------
>
> Key: DERBY-3722
> URL: https://issues.apache.org/jira/browse/DERBY-3722
> Project: Derby
> Issue Type: Sub-task
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.5.0.0
>
> Attachments: derby-3722-1.diff, derby-3722-1.stat, derby-3722-2.diff,
> derby-3722-2.stat
>
>
> When a role is granted to another role (with the GRANT <role> statement), we
> need to check that the grant relation does not give rise to a circularity.
> This is described in Section 12.5, Syntax rule 1 of ISO/IEC 9075-2 2003.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
